Location structure for transit and internal ( i.e. RV maps or the distributor internal logic ) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yb01
requested review from
Sindica,
sonyafenge and
q131172019
and removed request for
Sindica and
sonyafenge
Sindica
reviewed
Jul 1, 2022
q131172019
reviewed
Jul 1, 2022
q131172019
reviewed
Jul 1, 2022
There was a problem hiding this comment.
Use two AWS t2.2xlarge EC2 instances running on Ubuntu20.04 to run global resource service and one resource region manager simulator for Beijing region for 40+ minutes without issue.
-- global resource service:
ubuntu@ip-172-31-4-135:~/go/src/global-resource-service$ go run resource-management/cmds/service-api/service-api.go --resource_urls=ec2-34-222-30-69.us-west-2.compute.amazonaws.com:9129 -v=6
--- simulator for Beijing:
ubuntu@ip-172-31-4-135:~/go/src/global-resource-service$ go run resource-management/test/resourceRegionMgrSimulator/main.go --region_name=Beijing --rp_num=20 --nodes_per_rp=10000 --master_port=9129 -v=6
|
issue #68 created to track the renaming of the TransitResourceVersions type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this explicitly renamed the RP map structure with two different location types so the change will NOT accidentally mis use the types either for internal usage or the in-transit use. this will help up in the future to refactor the code or re-consider the RV approach post 630