Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade golang to 1.17 #63

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Conversation

sonyafenge
Copy link
Collaborator

fix Issue: #60

@sonyafenge sonyafenge requested a review from yb01 June 30, 2022 00:07
Copy link
Collaborator

@q131172019 q131172019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my local MAC environment, after I set GOPATH and GOROOT using go.1.17.x, under ~/global-resource-service, I move go.mod and go.sum to /tmp, then I run the commands:

go mod init global-resource-service
go mod tidy

Two new files go.mod and go.sum are created without problem, which contain a little more changes than the two files in this PR. But It is OK, we can update later.

Then test Redis + global resource service + simulator with newest codes + cherry-pick PR#39, so far so good.

Copy link
Collaborator

@q131172019 q131172019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@yb01 yb01 merged commit 0dea10e into CentaurusInfra:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants