Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update csv report format for service log #136

Merged
merged 2 commits into from
Aug 11, 2022
Merged

update csv report format for service log #136

merged 2 commits into from
Aug 11, 2022

Conversation

sonyafenge
Copy link
Collaborator

@sonyafenge sonyafenge commented Aug 11, 2022 •
edited
Loading

Fix issue: #121

  1. update csv report format for service log. new report looks like below:
grs-down-dismt-server-us-central1-a-mig-km47.log        
Metrics Item perc50 perc90 perc99 Total count
[Metrics][AGG_RECEIVED] 472.068308ms 492.31548ms 493.660315ms 49597
[Metrics][DIS_RECEIVED] 475.231211ms 495.325069ms 496.804886ms 49597
[Metrics][DIS_SENDING] 487.588358ms 513.560506ms 529.182632ms 49597
[Metrics][DIS_SENT] 487.594701ms 513.584962ms 529.216117ms 49597
[Metrics][SER_ENCODED] 491.299825ms 516.377763ms 530.762165ms 49597
[Metrics][SER_SENT] 491.299948ms 516.379486ms 530.762248ms 49597
  1. add "LOCAL_LOG_ONLY" for debug purpose. Default value is false and logs will be copied to official log server. for Debug purpose, you can set LOCAL_LOG_ONLY=true, then logs only copied to local dev machine:
export LOCAL_LOG_ONLY=true
./hack/test-logcollect.sh

@sonyafenge sonyafenge requested a review from yb01 August 11, 2022 20:23
@sonyafenge sonyafenge force-pushed the public-servicelogcsv branch from 8c85e04 to 9d10733 Compare August 11, 2022 20:28
yb01
yb01 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@yb01 yb01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yb01 yb01 merged commit 4dc5d0e into CentaurusInfra:main Aug 11, 2022
@sonyafenge sonyafenge mentioned this pull request Aug 12, 2022
Closed
@sonyafenge sonyafenge deleted the public-servicelogcsv branch October 13, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yb01 yb01 yb01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonyafenge @yb01