[BugFix] #104 - simulator: panic: invalid argument to Intn #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yb01
reviewed
Aug 9, 2022
| @@ -30,6 +30,23 @@ func main() { | |||
| flag.Parse() | |||
| } | |||
|
|
|||
| // Input parameter error handling for c.RpNum and c.NodesPerRP | |||
| // Fix bug #104 | |||
| if c.RpNum < 1 || c.NodesPerRP < 1 { | |||
There was a problem hiding this comment.
this OR is not needed. since you are error and exit for those two cases, yo can just check them individually as the code below and exit if condition checks true
There was a problem hiding this comment.
I want to avoid using "os.Exit(1)" twice.
There was a problem hiding this comment.
You can see my second commit.
yb01
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to simply fix the bug #104 by adding the check to ensure input command line parameters for Nodes Per RP or RP Number Per Region is greater than 0.