-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically start e2e testing #105
Conversation
SCHEDULER_REQUEST_MACHINE=${SCHEDULER_REQUEST_MACHINE:-"25000"} | ||
SCHEDULER_REQUEST_LIMIT=${SCHEDULER_REQUEST_LIMIT:-"26000"} | ||
SCHEDULER_NUM=${SCHEDULER_NUM:-"16"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason default to 16? and also, is 14 scheduler instances per machine too many ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have default 2 sim and total 400k nodes, CHEDULER_REQUEST_MACHINE is 25000, so set to 16 scheduler to meet with total nodes.
for this setup, scheduler number per machine are dynamic assigned based on total scheduler_num and client machine numbers.
so far, out testing using 3 client machines and 40 schedulers are working well.
hack/test-rune2e.sh
Outdated
fi | ||
fi | ||
|
||
echo "Waiting 60 seconds to get simulator running" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that seems too long for the wait.... on my local dev, a few seconds is more than enough to have simulator up to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to 10 seconds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Automatically start e2e testing:
more information can be found from #95