Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #71 by improving the robustness of Java runtime detection. The changes add defensive checks to prevent crashes when Java-related directories don't exist on the system, and enhance logging to help diagnose Java detection issues.
Changes:
- Added early initialization of JavaManager during app startup to trigger Java search
- Added defensive file existence checks before accessing Java and Homebrew directories
- Improved error handling for Homebrew directory access with proper logging
- Added detailed logging output showing all detected Java installations with their properties
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PCL.Mac/App/AppDelegate.swift | Initialize JavaManager.shared during app startup to trigger Java detection early |
| PCL.Mac.Core/Services/JavaSearcher.swift | Add file existence checks and error handling for directory access to prevent crashes |
| PCL.Mac.Core/Models/JavaRuntime.swift | Add CustomStringConvertible conformance to JavaType for better logging output |
| PCL.Mac.Core/Managers/JavaManager.swift | Add detailed logging of detected Java runtimes with formatted output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.