Skip to content

Fixes for let function not deallocating nodes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zisserj wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fixes for let function not deallocating nodes #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e8bc2c
fix pick_iter
zisserj Aug 21, 2025
0b1826f
fixed multi_compose bug
zisserj Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions dd/cudd_add.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,9 +1541,11 @@ cdef class ADD:
'is not in an ADD '
'in this manager')
x[index] = g.node

else:
x[index] = Cudd_addIthVar(
self.manager, index)
tmp = Cudd_addIthVar(self.manager, index)
g = wrap(self, tmp)
x[index] = g.node
try:
r = Cudd_addVectorCompose(
self.manager, u.node, x)
Expand Down Expand Up @@ -1716,8 +1718,7 @@ cdef class ADD:
algebraic decision diagram maps
the assignment `var_values` to.
"""
# TODO: with_values
return next(self.pick_iter(u, care_vars), None)
return next(self.pick_iter(u, care_vars, with_values), None)

def pick_iter(
self,
Expand Down Expand Up @@ -1777,7 +1778,10 @@ cdef class ADD:
set(var_values).difference(support))
for m in _bdd._enumerate_minterms(
var_values, care_vars):
yield m
if with_values:
yield (m, value)
else:
yield m
r = Cudd_NextCube(gen, &cube, &value)
finally:
Cudd_GenFree(gen)
Expand Down