Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed project_overflow_menu file by resolving the Null Value handling… #113

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

NayanKaushik25
Copy link

Noticed that I was unable to run the application due to a Null Value handling error in the project_overflow_menu.dart file which I fixed after implementing the appropriate condition.

Note: This is not a Jira-listed issue. Just Something I found while examining the forked repository.

@@ -15,7 +15,7 @@ dependencies:
sdk: flutter

flutter_localization: ^0.1.12
intl: ^0.19.0
intl: ^0.20.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please down grade this again or at least state the reason for your upgrade.

Project? project =
await database.projectDAO.getProjectByName(widget.project.name);
if (project?.name == name) return;
if (name == null) return; // Handle user canceling the rename dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments.

Copy link
Contributor

@bakicelebi bakicelebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you did a bunch of renaming and refactoring. Can you please explain the issue (step by step how to reproduce) and how you solved it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants