Skip to content

Add swipe gesture support for card navigation #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

had33l
Copy link
Contributor

@had33l had33l commented Apr 24, 2025

Summary

This PR implements swipe gesture navigation for cards, allowing users to swipe left or right to switch between them by flinging and flicking the screen

Features

  • Swipe left/right to change cards
  • Maintains arrow button support as a fallback

Closes Feature Request: Enable Swipe Gestures to Navigate Between Cards #2467

@had33l
Copy link
Contributor Author

had33l commented Apr 24, 2025

Screen_Recording_20250424_123619_Catima.Debug.mp4

this is a video of the the feature implemented

@TheLastProject
Copy link
Member

It always comes down to swiping, huh? #2129, #2128, #85, #699, #1772, #1609, #1089, #925, #482, #192, #36 😅

We had swiping support before, but it was removed because I got a lot of complaint on Google Play reviews of it triggering by accident. We added volume button card change in #2100 to try to make the people who want swiping happy but seeing this issue and PR, I guess it didn't help...

I guess we can have swiping support, but we will need a setting to disable swiping (so people who hate swiping at least have an option). And I guess keeping the "switch cards with volume buttons" feature makes no sense to keep then, so we should remove that.

Anyway, I don't know what happened with your PR, but you have unrelated changes and a merge conflict in there. You probably want to rebase this.

Also, it's very confusing that swiping on the barcode instead opens fullscreen mode and swiping on the thumbnail is completely ignored, that seems like a bug in this PR.

@TheLastProject
Copy link
Member

And I guess keeping the "switch cards with volume buttons" feature makes no sense to keep then, so we should remove that.

This I (or someone else) can do later, separate from this MR btw :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants