Meal Editor Logging - #648
Merged
Merged
Conversation
greinard
reviewed
Jul 31, 2026
greinard
approved these changes
Aug 3, 2026
| setDeviceInfo(info); | ||
| getMealToEdit().then(mealReference => { | ||
| if (mealReference) { | ||
| logMealEvent("editing-started", undefined, info, `Editing meal id=${mealReference.id}`); |
Collaborator
There was a problem hiding this comment.
If you update logMealEvent to accept a meal id instead of a meal, you could just pass mealReference.id here.
Contributor
Author
There was a problem hiding this comment.
That's true, but I think in general it's cleaner to pass the meal. Plus it gives us flexibility if we need to log other things about the meal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add custom event logging to the meal editor for troubleshooting image uploads.
Security
Testing
Test meal editor in web/mobile and ensure custom events are logged.
Documentation
@CareEvolution/api-docs.Reviewers
Assign to the appropriate reviewer(s). Minimally, a second set of eyes is needed ensure no non-public information is published. Consider also including:
Consider "Squash and merge" as needed to keep the commit history reasonable on
main.