fix(cli): keep TUS upload failure detail instead of "unknown error" - #2933
Merged
riderx merged 1 commit intoAug 8, 2026
Merged
Conversation
Port the working error handler from build/request.ts into uploadTUS. The onError handler parsed the response body outside a try/catch and, on an empty body, collapsed to the literal string "unknown error" while dropping the HTTP status, request URL, and raw body. A non-JSON proxy page (502/504) threw a SyntaxError inside the tus callback instead of rejecting cleanly. Now the parse is wrapped in a try/catch that falls back to the raw body then the tus error message, the status and URL are included in the message, and a real Error is rejected instead of a bare string. Generated-By: PostHog Code Task-Id: 95f63bcd-1e34-43b5-9bc9-cc0b870250eb
Contributor
Merging this PR will not alter performance
Comparing 
Footnotes
|
|
riderx
marked this pull request as ready for review
August 8, 2026 17:13
riderx
deleted the
posthog-self-driving/fixcli-keep-tus-upload-failure-detail-ce6790
branch
August 8, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capgo bundle uploadwith an empty response body reached the user as the literal stringunknown error— the HTTP status, request URL, and raw body were all dropped. This minted a fresh error tracking issue per occurrence and left both the user and the team unable to act.uploadTUSonErrorhandler ranJSON.parseoutside any try/catch and rejected a bare string, so an empty body collapsed tounknown errorand a non-JSON proxy page (HTML 502/504) threw aSyntaxErrorinside the tus callback.cli/src/build/request.ts— wrap the parse in a try/catch that falls back to the raw body then the tus error message, add the HTTP status and request URL to the message, and reject a realError.unknown errorTUS upload failed (status 502, url …): <body or tus message>SyntaxErrorthrown in callbackErrorinvalid_apikey,app_not_found, …)Test plan
invalid_apikey,app_not_found,insufficient_permissions) — those still surface their real cause.Errorcarrying the status, URL, and body instead ofunknown error.Screenshots
Checklist
bun run lint:backend && bun run lint.accordingly.
my tests
Agent context
cli/src/utils.tsbut fixes the neighbouring$exception_fingerprintproblem infindSavedKey; it leaves theuploadTUShandler alone, so the two do not conflict.Created with PostHog Desktop from this inbox report.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.