Skip to content

Fix ck2yaml handling of unnamed surfaces #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

Conversation

speth
Copy link
Member

@speth speth commented Apr 21, 2025

Changes proposed in this pull request

  • Fix ck2yaml's handling of surface phase definitions that don't provide a name

If applicable, fill in the issue number this pull request is fixing

Closes #1845

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth added the Input Input parsing and conversion (for example, ck2yaml) label Apr 21, 2025
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.36%. Comparing base (3f2057c) to head (61ca326).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1876   +/-   ##
=======================================
  Coverage   74.36%   74.36%           
=======================================
  Files         443      443           
  Lines       55407    55407           
  Branches     9105     9105           
=======================================
+ Hits        41201    41203    +2     
+ Misses      11108    11107    -1     
+ Partials     3098     3097    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ischoegl ischoegl merged commit 84831a9 into Cantera:main Apr 22, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input Input parsing and conversion (for example, ck2yaml)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ck2yaml in v3 can't convert the same files as v2
2 participants