Skip to content

Conversation

mugge6
Copy link
Member

@mugge6 mugge6 commented Apr 17, 2024

Tree node locator is comparing always the first and last child element with the current node to decide if the requested item was found on the current page. If there is a umlaut (äöü) on the key this doesn't work, because a simple comparison with < or > is based on their ASCI code. This fix will replace the comparison with the localeCompare function.

This fix should be contributed to Pimcore as soon as Cando will support one of the current versions from Pimcore.

Copy link

Review Checklist

  • Target branch (11.0 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant