Add bufferSizeMs parameter to stream recorder #905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you guys pls merge this ? |
|
This PR is stale because it has been open 90 days with no activity. Leave a comment or this will be closed in 7 days |
|
Thank your @ebraraktas for your contribution. |
|
Hi, I have a question. You seem to have modified my implementation by changing b256bf0#diff-b3f1bbf6e8d93255c518047daed27cd962f2cbb78ba7d33b554357b9cfecfff4R175 |
|
This is the capacity of the buffer in Octets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to resolve this issue. It adds
bufferSizeMsto recorder. Hence, one can record to a stream with chunks having specific size.NOTE: Current state of repository uses git dependencies for internal dependencies. They must be fixed once new versions are released.