DIG-1137, DIG-1618, DIG-1851: misc post-build script fixes #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daisieh
force-pushed
the
daisieh/post-build-fixes
branch
from
0ad2b57 to
b8faea0
Compare
OrdiNeu
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I consolidated all of the outputs into LOGFILE=progress.txt, since that file didn't seem to have anything useful in it anyway.
DIG-1137: only print out errors at the end for modules with errors or warnings
DIG-1618: remove orphan container warnings with env var COMPOSE_IGNORE_ORPHANS=true
DIG-1851: list the containers that are not running at the end. This is actually an improvement because I'm using the actual names of the expected vs running containers and not the counts, esp since additional containers like minio might be present.
On a running local build, you can test this by stopping various containers and then re-running
bash post_build.sh. You should see the missing containers listed at the end.