Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API authentication using token obtained from data portal #769

Merged
merged 6 commits into from
Oct 1, 2024
Merged

API authentication using token obtained from data portal #769

merged 6 commits into from
Oct 1, 2024

Conversation

OrdiNeu
Copy link
Contributor

@OrdiNeu OrdiNeu commented Sep 27, 2024

Ticket(s)

Description

  • This allows the user to grab a refresh token for use in API services (e.g. data ingest).
Screencast.from.2024-09-27.14-09-24.webm

Types of Change(s)

  • 🪲 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)

Has it been tested for:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • Prettier linter doesn't return errors
  • Production branch PR browser testing: Chrome, Firefox, Edge, etc.
  • Locally tested
  • Dev server tested
  • Production tested when merging into stable/production branch
  • Runbook tasks pass locally/on UHN-Dev
  • If visuals have changed, Runbook has been updated with new screenshots

@mshadbolt mshadbolt self-requested a review September 30, 2024 17:01
@OrdiNeu OrdiNeu force-pushed the feature/frontend-refresh-token branch from 0f74fc8 to e7bf7f8 Compare September 30, 2024 17:27
@OrdiNeu OrdiNeu force-pushed the feature/frontend-refresh-token branch from 9534fac to ad4721f Compare October 1, 2024 13:53
mshadbolt
mshadbolt approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@mshadbolt mshadbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@OrdiNeu OrdiNeu merged commit ac9be97 into develop Oct 1, 2024
2 checks passed
@OrdiNeu OrdiNeu deleted the feature/frontend-refresh-token branch October 1, 2024 18:13
daisieh pushed a commit that referenced this pull request Oct 4, 2024
@OrdiNeu @mshadbolt @daisieh
API authentication using token obtained from data portal (#769)
6702f8d 
* Add a method for users to get a refresh token from the frontend

* Fixup ux

* Forgot a .env change

* update ingest

* Post-merge pulls

---------

Co-authored-by: Marion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshadbolt mshadbolt mshadbolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrdiNeu @mshadbolt