Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a standalone SimpleNet example build to the CI #304

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jwallwork23
Copy link
Collaborator

@jwallwork23 jwallwork23 commented Mar 3, 2025

This PR adds an additional CI step to build and run one of the examples in a "standalone" fashion. This checks that we can build it with CMake separately from FTorch without needing to set LD_LIBRARY_PATH etc.

Checklist

  • Ubuntu
  • Windows
  • Mac?

@jwallwork23 jwallwork23 added the testing Related to FTorch testing label Mar 3, 2025
@jwallwork23 jwallwork23 self-assigned this Mar 3, 2025
@jwallwork23
Copy link
Collaborator Author

Huh, surprised that this fails as the following script works fine for me locally

#!/bin/bash

FTORCH_BUILD_DIR="$(pwd)/build"
cd examples/1_SimpleNet
export BUILD_DIR="$(pwd)/build"
rm -rf "${BUILD_DIR}"
mkdir "${BUILD_DIR}"
cd "${BUILD_DIR}"
cmake .. \
  -DPython_EXECUTABLE="$(which python)" \
  -DCMAKE_BUILD_TYPE=Release \
  -DCMAKE_PREFIX_PATH="${FTORCH_BUILD_DIR}" \
  -DCMAKE_BUILD_TESTS=TRUE
cmake --build .
ctest -V

@jatkinson1000
Copy link
Member

Yep, pretty sure this matches what I was getting.
Interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to FTorch testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants