Hook up requires_grad
#288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
added
enhancement
jwallwork23
commented
Feb 18, 2025
|
Static analysis CI error will be fixed by #287. |
jatkinson1000
requested changes
Mar 10, 2025
There was a problem hiding this comment.
Hi @jwallwork23 Generally seems sensible to me.
Main request is to test the defaults for requires_grad, not just the true setting.
I realise this probably needs a bit of tweaking/rebasing after a few of the recent changes.
jwallwork23
force-pushed
the
requires_grad
branch
from
660fae9 to
6b6a874
Compare
jwallwork23
commented
Mar 10, 2025
|
[Rebased on top of |
jatkinson1000
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Thanks @jwallwork23 an even better fix than I imagined.
Hopefully fixtures should come in useful as we expand things.
|
Thanks for the review @jatkinson1000! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #158.
(Refined from #286.)
This PR hooks the
requires_gradoption up properly and provides atorch_tensor_requires_gradfunction (as well as atorch_tensor%requires_gradmethod) to query this. Unit tests are written and the option is also used in the autograd example.