-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid copying examples when building tests #281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jwallwork23 CMake adjustments look fine, but I think you need to update the installation instructions on the main README
and in the pages/
directory to reflect that users no longer build in src/build/
.
Would be worth a comb through the rest of the READMEs and docs to check for anything else that may need changing.
Thanks @jatkinson1000 - I think I covered everything with e0e85d3. Grepped for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jwallwork23 On the assumption you catched 'em all I'm happy to approve this.
Closes #279.
Simplifies the developer experience, as discussed in today's meeting.
FTorch/src/CMakeLists.txt
moved toFTorch/CMakeLists.txt
.FTorch/src/tests/
moved toFTorch/tests/
.