MPI example #270
Merged
MPI example #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
added
documentation
jwallwork23
commented
Jan 30, 2025
|
I decided to drop MPI in the case of Windows for now. |
jwallwork23
force-pushed
the
257_mpi-example
branch
from
3059074 to
6784fe2
Compare
|
[Rebased on top of |
jwallwork23
force-pushed
the
257_mpi-example
branch
from
c01e029 to
f27bdf9
Compare
There was a problem hiding this comment.
Hi @jwallwork23 I reviewed this a week ago, but just realised I had not submitted it so all my comments were marked as 'pending', apologies.
Generally looks good, but left a couple of points around best practices for you to consider.
jwallwork23
force-pushed
the
257_mpi-example
branch
from
f27bdf9 to
41de027
Compare
|
[Rebased on top of |
jatkinson1000
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Thanks for implementing those suggestions @jwallwork23
Happy for this to be merged now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257.
This PR creates a CPU-only example using MPI similarly to how we had the multi-GPU example set up before #268.
It's set up to run the net with different input on each MPI rank then gather the outputs to the root rank and check the outputs were correct. There's also a check that the number of MPI ranks is greater than 1 to help identify any config errors.