Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: mismatch in Fortran array character array lengths in example 2 #263

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

jatkinson1000
Copy link
Member

@jatkinson1000 jatkinson1000 commented Jan 29, 2025

A mismatch in character array lengths was causing the wrong resnet category to be printed in the Fortran.

At some point lengths in the main routine were updated to 128, but not in the subroutine required to read categories leading to the arrays becoming garbled during the passing.

Also updates the filename strings to 128 for consistency, rather than seemingly arbitrary lengths.

…2 causing the wrong resnet category to be printed.
Copy link
Collaborator

@jwallwork23 jwallwork23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jatkinson1000 jatkinson1000 merged commit 2cd3d09 into main Jan 29, 2025
5 checks passed
@jatkinson1000 jatkinson1000 deleted the eg2_fortran_bugfix branch January 29, 2025 12:37
jatkinson1000 added a commit that referenced this pull request Feb 25, 2025
#263)

* Bugfix: mismatch in Fortran array character array lengths in example 2 causing the wrong resnet category to be printed.

* Update filename strings to len=128 in example 2 for consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants