-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply CMake formatting #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @jwallwork23
Changes all look good to me.
As ever, needs a short comment/link adding to the documentation ;)
I'd also suggest putting cmakelang in the requirements.txt rather than pip installing it on its own.
My New Years resolution will be to write the docs with the code 👼
Good point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send it!
Today I discovered a CMake formatter: https://github.com/cheshirekow/cmake_format.
Seems like a good idea to add to the static analysis workflow. I did need to disable the formatter in a couple of places with particularly long lines.
(Most of the changes in this PR are auto-formatting changes.)