Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply CMake formatting #204

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Apply CMake formatting #204

merged 8 commits into from
Dec 10, 2024

Conversation

jwallwork23
Copy link
Collaborator

@jwallwork23 jwallwork23 commented Dec 10, 2024

Today I discovered a CMake formatter: https://github.com/cheshirekow/cmake_format.

Seems like a good idea to add to the static analysis workflow. I did need to disable the formatter in a couple of places with particularly long lines.

(Most of the changes in this PR are auto-formatting changes.)

@jwallwork23 jwallwork23 added the enhancement New feature or request label Dec 10, 2024
@jwallwork23 jwallwork23 self-assigned this Dec 10, 2024
@jwallwork23 jwallwork23 marked this pull request as ready for review December 10, 2024 10:09
Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @jwallwork23

Changes all look good to me.
As ever, needs a short comment/link adding to the documentation ;)

I'd also suggest putting cmakelang in the requirements.txt rather than pip installing it on its own.

@jwallwork23
Copy link
Collaborator Author

Changes all look good to me. As ever, needs a short comment/link adding to the documentation ;)

My New Years resolution will be to write the docs with the code 👼

I'd also suggest putting cmakelang in the requirements.txt rather than pip installing it on its own.

Good point.

@jwallwork23
Copy link
Collaborator Author

Changes all look good to me. As ever, needs a short comment/link adding to the documentation ;)

Addressed in 7719c8e.

I'd also suggest putting cmakelang in the requirements.txt rather than pip installing it on its own.

Addressed in 60c16df.

Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Send it!

@jwallwork23 jwallwork23 merged commit d359b19 into main Dec 10, 2024
4 checks passed
@jwallwork23 jwallwork23 deleted the cmake-format branch December 10, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants