-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: make integration tests cross-platform #203
Conversation
ab707c6
to
2521e29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible.
So when searching for python and implicitly setting Python_EXECUTABLE
this does now work OK on Windows?
Since we don't set this now as far as I can see.
GitHub flags the python scripts as changed, but then shows no lines changed listing it as an 'empty file'. Is this because it interprets the removal of a shebang in a strange way?
This is set by
No, it because the permissions were changed from executable (755) to read/write (644). There is no way for github to display that info. It's a bit like when you rename a file. There are zero changes to the file contents but the git metadata changes. |
2521e29
to
acb216d
Compare
@TomMelt OK, so are we leaving the shebangs in the files? |
f1c00fe
to
5b79f59
Compare
my bad... now I understand you. I hadn't pushed that commit yet 🤦 You can now see the shebang removal 👌 |
5b79f59
to
966fbd4
Compare
this makes the integration tests more portable.
CMakeLists.txt
to require python interpreter (for building tests only) and usePython_EXECUTABLE
which is set byfind_package (Python COMPONENTS Interpreter REQUIRED)