-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS paper submission #200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
reviewed
Feb 11, 2025
jwallwork23
reviewed
Feb 11, 2025
jwallwork23
reviewed
Feb 11, 2025
jwallwork23
reviewed
Feb 11, 2025
jwallwork23
reviewed
Feb 11, 2025
jwallwork23
reviewed
Feb 11, 2025
jwallwork23
reviewed
Feb 11, 2025
jwallwork23
reviewed
Feb 11, 2025
jwallwork23
reviewed
Feb 11, 2025
jwallwork23
reviewed
Feb 11, 2025
jatkinson1000
commented
Feb 11, 2025
Co-authored-by: Joe Wallwork <[email protected]>
jwallwork23
reviewed
Feb 19, 2025
Co-authored-by: Joe Wallwork <[email protected]>
jwallwork23
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor optional suggested tweaks, but otherwise reads very well to me!
Co-authored-by: Joe Wallwork <[email protected]>
…other supporting softwares for linting.
jwallwork23
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains the FTorch submission for JOSS.
It will be kept up to date with the
main
branch (rebasing) throughout the review process.Further additions to the paper will be made via commits to this
JOSS
branch.Once review is complete we will merge it into main along with a citation.cff file and other post-review actions.
Review is at openjournals/joss-reviews#7602 (comment)