test(vault): max_deduct boundary coverage (#152)#221
Merged
greatest0fallt1me merged 6 commits intoCalloraOrg:mainfrom Mar 31, 2026
Merged
test(vault): max_deduct boundary coverage (#152)#221greatest0fallt1me merged 6 commits intoCalloraOrg:mainfrom
greatest0fallt1me merged 6 commits intoCalloraOrg:mainfrom
Conversation
- Audited all privileged entrypoints in vault, revenue_pool, and settlement - Added negative require_auth tests to each crate's test.rs - Fixed pre-existing setup_contract missing third_party in settlement tests - Documented intentional exceptions: settlement::init and vault::require_owner - Updated SECURITY.md with audit findings and cross-references - All 180 tests pass Closes CalloraOrg#160
- Audited all privileged entrypoints in vault, revenue_pool, and settlement - Added negative require_auth tests to each crate's test.rs - Fixed pre-existing setup_contract missing third_party in settlement tests - Documented intentional exceptions: settlement::init and vault::require_owner - Updated SECURITY.md with audit findings and cross-references - All 180 tests pass Closes CalloraOrg#160
- Audited all privileged entrypoints in vault, revenue_pool, and settlement - Added negative require_auth tests to each crate's test.rs - Fixed pre-existing setup_contract missing third_party in settlement tests - Documented intentional exceptions: settlement::init and vault::require_owner - Updated SECURITY.md with audit findings and cross-references - All 180 tests pass Closes CalloraOrg#160
|
@Sam-Rytech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 5 boundary tests for
max_deductincontracts/vault/src/test.rscovering all requirements from #152.Tests added
deduct_equal_to_max_deduct_succeeds— single deduct exactly at the cap passesdeduct_above_max_deduct_panics— single deduct one unit above cap is rejecteddeduct_default_cap_is_i128_max— unsetmax_deductdefaults toi128::MAX; large deduct succeedsbatch_deduct_each_item_constrained_by_max_deduct— three batch items each at the cap all passbatch_deduct_one_item_above_max_deduct_panics— one oversized item in a batch is rejectedTest output
125 passed; 0 failed — finished in 2.24s
Security notes
max_deduct, aligning with backend metering batch constraintsi128::MAX) is verified to be the fallback whenmax_deductis unset at initCloses #152