ci: enforce WASM size checks for all publishable contracts#216
Merged
greatest0fallt1me merged 2 commits intoCalloraOrg:mainfrom Mar 31, 2026
Merged
Conversation
|
@iammrjude Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Closes #138
This PR extends the WASM size check so CI covers every publishable Soroban contract crate in the workspace instead of relying on a hard-coded package list.
What changed
scripts/check-wasm-size.shto:contracts/*/Cargo.tomlcdylibtargetreleaseprofile.github/workflows/ci.ymlto run the size-check script withbashcargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test./scripts/check-wasm-size.shcontracts/settlement/src/test.rsso the workspace passesclippyandcargo testcargo fmt --all --checkValidation
Ran locally from the workspace root:
cargo fmt --allcargo fmt --all --checkcargo clippy --all-targets --all-features -- -D warningscargo testbash ./scripts/check-wasm-size.shcargo build --target wasm32-unknown-unknown --release -p callora-vaultstellar contract build --package callora-vaultcargo tarpaulin --config tarpaulin.tomlWASM size results
callora-revenue-pool:21070bytescallora-settlement:24127bytescallora-vault:36975bytesAll publishable contract WASM artifacts are below the
65536byte Soroban limit.Coverage
98.16%(586/597lines covered)Security notes
[profile.release]settings in the workspaceCargo.tomlcdylibcontract crates, helping prevent unnoticed size regressions