Skip to content

Securestorage#274

Open
Cofez wants to merge 2 commits intoCalebux:mainfrom
Cofez:securestorage
Open

Securestorage#274
Cofez wants to merge 2 commits intoCalebux:mainfrom
Cofez:securestorage

Conversation

@Cofez
Copy link
Copy Markdown

@Cofez Cofez commented Mar 30, 2026

Rename misleading secureStorage to encodedStorage and clarify that base64 encoding is not encryption.

  • Renamed export from secureStorage to encodedStorage in client/lib/security-utils.ts
  • Replaced misleading "Secure storage wrapper" comment with a clear warning that this is base64 encoding, not encryption, and must not be used for sensitive data (API keys, tokens, passwords)
  • Renamed internal variables from encrypted to encoded to accurately reflect behavior
  • Changed value parameter type from any to unknown for type safety
  • Audited all call sites: zero external consumers found, so no additional migration needed

Related Issue

Closes #117


Test Plan

  • Tested locally
  • Verified expected behavior
  • No regressions introduced
  • Audited all imports of security-utils — only SessionManager is imported elsewhere; secureStorage had no consumers
  • Confirmed no sensitive data (API keys, tokens) flows through this utility

Screenshots (if applicable)

N/A — no UI changes.


Checklist

  • Code builds successfully
  • Tests pass
  • Follows project conventions
  • No sensitive data exposed

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 30, 2026

@Cofez Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security: secureStorage uses btoa (base64) not encryption — sensitive data is trivially readable

1 participant