feat: standardise backend error responses to RFC 7807#269
Open
Robinsonchiziterem wants to merge 1 commit intoCalebux:mainfrom
Open
feat: standardise backend error responses to RFC 7807#269Robinsonchiziterem wants to merge 1 commit intoCalebux:mainfrom
Robinsonchiziterem wants to merge 1 commit intoCalebux:mainfrom
Conversation
|
@Robinsonchiziterem Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Open
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #172 Add standardized error response format (RFC 7807 Problem Details) across all backend routes
Description
This PR completely standardizes the SYNCRO backend and SDK error responses around the RFC 7807 Problem Details specification for HTTP APIs.
Key changes include:
AppErrorbase class hierarchy (NotFoundError,ValidationError,ConflictError,ForbiddenError, etc.).validateRequest) and migrated all backend routes (subscriptions,merchants,team,api-keys,audit, etc.) to throw semantic errors natively instead of relying on legacy, disparateres.status().json(...)blocks.sdk/src/index.tsandsdk/src/errors.ts) to natively parse, extract, and re-throw these RFC 7807 HTTP errors for clean client-side consumption.Related Issue
Closes #172
Test Plan
detailorextensions)tscare currently failing onmainwithinsrc/services/due to broken upstream merges from PR Fix/137 event listener health retry #260, which blocks full end-to-end regression validation)Screenshots (if applicable)
N/A
Checklist
main)main)Closes #172