closes #167 Add end-to-end tests with Playwright covering critical user flows#240
Open
Joeltabe wants to merge 2 commits intoCalebux:mainfrom
Open
closes #167 Add end-to-end tests with Playwright covering critical user flows#240Joeltabe wants to merge 2 commits intoCalebux:mainfrom
Joeltabe wants to merge 2 commits intoCalebux:mainfrom
Conversation
…ncro Add Playwright E2E coverage for critical SYNCRO user journeys
|
@Joeltabe Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167
Motivation
Description
client/playwright.config.tswithe2etest directory, CI retries, trace/screenshot diagnostics, and desktop + mobile (Pixel 5) projects.client/e2e/helpers.tsfor generating unique test users, API signup/login, bootstrapping a mocked authenticated UI, and navigation helpers.client/e2e/auth.spec.ts(signup & login) andclient/e2e/subscription-flows.spec.ts(add, edit, delete subscription; notifications visibility; settings update).e2e,e2e:headed,e2e:report) toclient/package.jsonand a GitHub Actions workflow.github/workflows/e2e.ymlto run Playwright against a preview deployment URL provided viaE2E_BASE_URL, install browsers, and upload reports/artifacts on success/failure.Testing
npm run lintinclientand it failed due to ESLint v9 requiring a flateslint.config.*file, so linting did not complete.npm run e2e -- --listlocally to enumerate tests but Playwright could not be installed here because the environment returned403 Forbiddenwhen fetching Playwright packages, so the E2E suite could not be executed locally.E2E_BASE_URL) and will upload HTML reports and failure artifacts for diagnostics when run in GitHub Actions.