chore: Update package dependencies and ESLint configuration in backen…#238
Open
D240021 wants to merge 1 commit intoCalebux:mainfrom
Open
chore: Update package dependencies and ESLint configuration in backen…#238D240021 wants to merge 1 commit intoCalebux:mainfrom
D240021 wants to merge 1 commit intoCalebux:mainfrom
Conversation
|
@D240021 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #110
Summary
This issue introduced CI lint enforcement across both application packages to prevent inconsistent code style, unused imports/variables, and risky TypeScript patterns from being merged into
main.Changes Implemented
.github/workflows/lint.yml.pushtomainpull_requesttargetingmainlint-backend(runs inbackend/)actions/checkout@v4actions/setup-node@v4with Node.js20npm cinpx eslint src --ext .ts --max-warnings 0lint-client(runs inclient/)actions/checkout@v4actions/setup-node@v4with Node.js20npm cinpx next lintESLint Configuration Added
backend/.eslintrc.cjs.client/.eslintrc.cjs.@typescript-eslint/no-explicit-any: error@typescript-eslint/no-floating-promises: errorno-console: warn@typescript-eslint/no-unused-vars: errorDependency and Tooling Updates
backendandclientto support the new lint rules and CI execution.npm ci.backend/package-lock.json, because the backend lint workflow explicitly depends on it.Current Validation Status
backendandclientthat must be cleaned up to fully satisfy the “no existing lint errors remain after initial cleanup” acceptance criterion.Notes
I remain open to any corrections or feedback you may have.