Skip to content

chore: Update package dependencies and ESLint configuration in backen…#238

Open
D240021 wants to merge 1 commit intoCalebux:mainfrom
D240021:main
Open

chore: Update package dependencies and ESLint configuration in backen…#238
D240021 wants to merge 1 commit intoCalebux:mainfrom
D240021:main

Conversation

@D240021
Copy link
Copy Markdown

@D240021 D240021 commented Mar 27, 2026

Closes #110


Summary

This issue introduced CI lint enforcement across both application packages to prevent inconsistent code style, unused imports/variables, and risky TypeScript patterns from being merged into main.

Changes Implemented

  • Added a new GitHub Actions workflow at .github/workflows/lint.yml.
  • Configured the workflow to run on:
    • push to main
    • pull_request targeting main
  • Added two lint jobs:
    • lint-backend (runs in backend/)
      • actions/checkout@v4
      • actions/setup-node@v4 with Node.js 20
      • npm ci
      • npx eslint src --ext .ts --max-warnings 0
    • lint-client (runs in client/)
      • actions/checkout@v4
      • actions/setup-node@v4 with Node.js 20
      • npm ci
      • npx next lint

ESLint Configuration Added

  • Created backend/.eslintrc.cjs.
  • Created client/.eslintrc.cjs.
  • Enforced the requested rules in both packages:
    • @typescript-eslint/no-explicit-any: error
    • @typescript-eslint/no-floating-promises: error
    • no-console: warn
    • @typescript-eslint/no-unused-vars: error

Dependency and Tooling Updates

  • Added required ESLint dependencies in both backend and client to support the new lint rules and CI execution.
  • Added/updated lockfiles as needed for reproducible CI installs with npm ci.
  • Updated ignore behavior to allow tracking backend/package-lock.json, because the backend lint workflow explicitly depends on it.

Current Validation Status

  • The lint workflow and ESLint configuration are in place and active as required.
  • CI now correctly fails on lint errors.
  • There are still pre-existing lint violations in both backend and client that must be cleaned up to fully satisfy the “no existing lint errors remain after initial cleanup” acceptance criterion.

Notes

  • This implementation focused strictly on the scope defined in the issue: CI lint enforcement, ESLint rule setup in both packages, and initial execution/validation of lint checks.

I remain open to any corrections or feedback you may have.

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 27, 2026

@D240021 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GitHub Actions CI: ESLint and code quality enforcement

1 participant