WIP: Helpers keep default config for robustness#195
Closed
Erwane wants to merge 1 commit intocake4-bs4-1.0.0from
Closed
WIP: Helpers keep default config for robustness#195Erwane wants to merge 1 commit intocake4-bs4-1.0.0from
Erwane wants to merge 1 commit intocake4-bs4-1.0.0from
Conversation
Codecov Report
@@ Coverage Diff @@
## cake4-bs4-1.0.0 #195 +/- ##
=====================================================
+ Coverage 86.63% 87.32% +0.68%
- Complexity 380 382 +2
=====================================================
Files 19 19
Lines 1190 1183 -7
=====================================================
+ Hits 1031 1033 +2
+ Misses 159 150 -9
Continue to review full report at Codecov.
|
Holt59
reviewed
Nov 17, 2020
| * @return string The classes for the size or offset of the specified column. | ||
| */ | ||
| protected function _getColumnClass(string $what): string | ||
| public function getColumnClass(string $what): string |
Collaborator
There was a problem hiding this comment.
Is there any reason for this to be made public? And the _ prefix is CakePHP convention for protected methods, any reason you removed it from most methods?
Collaborator
Author
There was a problem hiding this comment.
My phpcs was misconfigured in my IDE. Sorry
Holt59
reviewed
Nov 17, 2020
| { | ||
| // Standard form | ||
| $this->assertHtml([ | ||
| self::assertHtml([ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a try to prevent addition in Cake helpers will break the code.
Bootstrap helper is in
$helperConfigand merged to$_defaultConfig. This way, templates and widgets always have a correct default and follow framework.Work in progress, need to do all helpers if good way.