-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cleanup: Remove default and invalid values
There is no reason to have this shipped in our configuration, especially now that the configuration resides in the root directory, and will NEVER be touched by the user. A couple of things that have been removed: - cursor.allow_dumb_copy - We disable hw cursor for NVIDIA so there is no reason for this to be enabled. - Dropped "epic-mouse-v1" - WTF is this? - misc.vfr - vfr is boolean so 1 is invalid. I assume this should be VRR, in which case 1 is also just a bad default Signed-off-by: Eric Naim <[email protected]>
- Loading branch information
Showing
3 changed files
with
3 additions
and
82 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c259245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no_hardware_cursors = 2 is the replacement for nvidia cursor situation now automatically detecting it. allow_dumb_copy will be replace by use_cpu_buffer (hyprwm/Hyprland#8424 (comment))
Default from the hyprland.conf file.
The VFR is not invalid:
vfr = 1 is correct https://wiki.hyprland.org/0.45.0/Configuring/Variables/#variable-types.
vfr: "controls the VFR status of Hyprland. Heavily recommended to leave enabled to conserve resources."
c259245
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's disabled. No reason to set this.
So why do we need to set it in the conf file again?
Yeah, I missed that. But it's default true so it doesn't matter. With boolean stuff in mind, you're not consistent with the types being used, sometimes there's
true
, other times there'syes
and here you're using1
. I changed any occurences ofyes
totrue
but please be consistent in one type next time.