fix: set timeout: 3600 on create-pacman-keyring step - #237
Open
chrisdebian wants to merge 1 commit into
Open
Conversation
The create-pacman-keyring script runs pacman-key --init (entropy generation) and two pacman -Sy loops to download cachyos-keyring and archlinux-keyring. On physical hardware with limited entropy sources or slow mirrors, this easily exceeds the module default of 30 seconds, causing the installer to abort at the "initialize pacman" step. update-mirrorlist already has timeout: 3600 for the same reason. Apply the same setting to create-pacman-keyring. Fixes CachyOS#236
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #236.
create-pacman-keyringhad no explicit timeout, so it used the module default of 30 seconds. The script runspacman-key --init(entropy generation) plus twopacman -Syretry loops to downloadcachyos-keyringandarchlinux-keyring. On physical hardware this reliably exceeds 30 seconds, aborting the installation at the "initialize pacman" step.update-mirrorlistalready hastimeout: 3600for exactly this reason. This PR applies the same setting tocreate-pacman-keyring.Change
One line added; no logic changed.