installer: Add fallback ping checks for the internet check #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Jung <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances internet connectivity checking in the installer by adding fallback ping tests when the primary HTTP check fails. This addresses accessibility issues in censored countries where the main CachyOS website may be blocked due to Cloudflare proxy usage.
- Restructures connectivity check to try HTTP first, then fallback to ping tests
- Adds ping tests to three reliable DNS servers (Google, Cloudflare, Quad9)
- Improves connectivity detection reliability in restrictive network environments
| } | ||
| true | ||
|
|
||
| // If HTTP check fails, try ping fallback to reliable DNS servers |
There was a problem hiding this comment.
The comment on line 109 mentions '8.8.8.8 (Cloudflare)' but 8.8.8.8 is actually Google's DNS server, not Cloudflare's. 1.1.1.1 is Cloudflare's DNS server.
Suggested change
| // If HTTP check fails, try ping fallback to reliable DNS servers | |
| // If HTTP check fails, try ping fallback to reliable DNS servers (8.8.8.8 - Google, 1.1.1.1 - Cloudflare, 9.9.9.9 - Quad9) |
Copilot uses AI. Check for mistakes.
Co-authored-by: Vladislav Nepogodin <[email protected]>
Co-authored-by: Vladislav Nepogodin <[email protected]>
Co-authored-by: Vladislav Nepogodin <[email protected]>
Co-authored-by: Vladislav Nepogodin <[email protected]>
Co-authored-by: Vladislav Nepogodin <[email protected]>
Co-authored-by: Vladislav Nepogodin <[email protected]>
mikaeldui
reviewed
Jul 20, 2025
|
|
||
| // If HTTP check fails, try ping fallback to reliable DNS servers | ||
|
|
||
| for target in ["8.8.8.8", "1.1.1.1", "9.9.9.9"] { |
There was a problem hiding this comment.
Suggested change
| for target in ["8.8.8.8", "1.1.1.1", "9.9.9.9"] { | |
| for target in ["2001:4860:4860::8888", "2606:4700:4700::1111", "2620:fe::fe", "8.8.8.8", "1.1.1.1", "9.9.9.9"] { |
Add IPv6 targets and prefer them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In censored countries it is often not possible to ping "cachyos.org" since we are using cloudflare proxy for the website.
Add a fallback ping of 1.1.1.1 (Cloudflare), 8.8.8.8 (Cloudflare), 9.9.9.9 (Quad 9) for the internet check