Conversation
For some reason, this does not have right match, and the next step will already fail if calamares has not started for some reason, so it's fine to replace it with simple timer. Signed-off-by: Vasiliy Stelmachenok <ventureo@cachyos.org>
Signed-off-by: Vasiliy Stelmachenok <ventureo@cachyos.org>
Signed-off-by: Vasiliy Stelmachenok <ventureo@cachyos.org>
ventureoo
changed the title
Member
Author
|
Ready to merge. Added fixes to ensure that logs are received correctly when falling. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Calamares installation UI test to make the launch step less dependent on OCR-matching an exact command string, and adjusts the failure handler’s keyboard navigation.
Changes:
- Wrap Calamares launch with
systemd-inhibitand replace a brittleqt_wait_for_textcheck with a short delay. - Add an extra
tabkeypress in the failure-handling path before activating the selected control.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ventureoo
marked this pull request as draft
June 15, 2026 08:28
ventureoo
marked this pull request as ready for review
June 16, 2026 15:21
Member
Author
|
The recent failures should be fixed in CachyOS/cachyos-calamares#238, it's not hard blocker, so for now it should be OK to merge. |
ptr1337
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, this does not have right match anymore, and the next step will already fail if calamares has not started for some reason, so it's fine to replace it with simple timer.