forked from cms-sw/cmssw
-
Notifications
You must be signed in to change notification settings - Fork 8
Iterative thresholds + DP correction #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tostafin
wants to merge
22
commits into
CTPPS:rolling-calib-timing-calibration-14_1_4
Choose a base branch
from
tostafin:rolling-calib-timing-calibration-14_1_4
base: rolling-calib-timing-calibration-14_1_4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Iterative thresholds + DP correction #92
tostafin
wants to merge
22
commits into
CTPPS:rolling-calib-timing-calibration-14_1_4
from
tostafin:rolling-calib-timing-calibration-14_1_4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tomasz Ostafin <[email protected]>
…with cms-merge-topic
The thresholdFractionOfMax parameter is removed and replaced by iterative thresholds plus fixed bounds to find the best fit based on chi^2 and ndf.
Adding implementation for correcting double peaks which sometimes occur in the leading edge histograms. The algorithm finds the LS at which the double peak happens, computes the required time offset and passes this information to the worker to correct t and t vs TOT histograms, as well as to the harvester to save it into the SQLite file.
fbe83a9 to
063c2fd
Compare
946fe02 to
0813d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.