Skip to content

Conversation

@Glitchmin
Copy link
Collaborator

PR description:

PR containing suggested changes regarding reconstruction error behaviour:

  • retuning invalid proton (not visible on the plots) if optics for a given track are not available
  • returning empty LHCInterpolatedOpticalFunctionsSetCollection if there is only one optical funtion and its xangle was different from the one in LHCInfo

PR validation:

  • To see the first case please replace the if statement in lines 178 & 422 to if(true) in file ProtonReconstructionAlgorithm.cc

  • To see the second case replace line 73 in CTPPSInterpolatedOpticalFunctionsESSource.cc to

  LHCOpticalFunctionsSetCollection const &ofColl2 = iRecord.get(opticsToken_);
  auto ofColl = ofColl2;
  auto it = ofColl.begin();
  while (ofColl.size()>1) {
      it = ofColl.erase(it);
  }

After that run the reco, for example using the file RecoPPS/Local/test/2023_lhcinfo_test_recoCTPPS_cfg.py from cms-sw#42515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants