Skip to content

Conversation

@grzanka
Copy link

@grzanka grzanka commented Jul 22, 2025

This pull request introduces improvements to the handling of track coordinates in the CTPPSDiamondDQMSource and CTPPSDiamondLocalTrackFitter modules. The changes focus on incorporating rotation and translation transformations for better alignment with the detector geometry and adding support for global-to-local and local-to-global coordinate conversions.

Enhancements in coordinate transformations:

  • DQM/CTPPS/plugins/CTPPSDiamondDQMSource.cc:
    • Replaced the use of diamShifts_ with diamTranslations_ and diamHalfWidths_ for more accurate local coordinate calculations. Rotation angles are now applied using diamRotations_ to adjust track positions. These changes impact the calculation of startBin for both 220nr_hr and 220cyl tracks. [1] [2] [3] [4] [5]

New support for global-to-local and local-to-global transformations:

  • RecoPPS/Local/plugins/CTPPSDiamondLocalTrackFitter.cc:
    • Introduced a new edm::ESGetToken for accessing CTPPSGeometry, enabling geometry-based transformations.
    • Added logic to transform hit and track coordinates from global to local and vice versa using detector-specific rotation and translation matrices. This ensures consistency in track positions across different coordinate systems. [1] [2] [3]

These changes improve the precision of track alignment and enhance compatibility with the detector geometry, which is critical for accurate data analysis.TODO

@grzanka grzanka marked this pull request as draft July 22, 2025 20:18
@grzanka grzanka self-assigned this Jul 23, 2025
… analysis and clean up CTPPSDiamondLocalTrackFitter by commenting out debug prints
@grzanka grzanka requested a review from Copilot July 23, 2025 18:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces improved coordinate transformation handling for CTPPS diamond detector track reconstruction. The changes implement proper global-to-local and local-to-global coordinate transformations using detector geometry information, replacing previous simplified shift-based calculations.

  • Integrates CTPPSGeometry for accurate coordinate transformations using rotation matrices and translation vectors
  • Updates track fitting to perform global-to-local coordinate conversion for hits and local-to-global conversion for output tracks
  • Replaces simplified shift calculations in DQM with proper local coordinate transformations using rotation angles

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
RecoPPS/Local/plugins/CTPPSDiamondLocalTrackFitter.cc Adds geometry-based coordinate transformations for hits and tracks, implementing bidirectional global/local conversions
DQM/CTPPS/plugins/CTPPSDiamondDQMSource.cc Updates track position calculations to use proper local coordinates with rotation transformations instead of simple shifts
Comments suppressed due to low confidence (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants