-
Notifications
You must be signed in to change notification settings - Fork 8
diamond track reconstruction with local coordinates #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…k outputs with detailed logging
…larity and performance
… analysis and clean up CTPPSDiamondLocalTrackFitter by commenting out debug prints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces improved coordinate transformation handling for CTPPS diamond detector track reconstruction. The changes implement proper global-to-local and local-to-global coordinate transformations using detector geometry information, replacing previous simplified shift-based calculations.
- Integrates CTPPSGeometry for accurate coordinate transformations using rotation matrices and translation vectors
- Updates track fitting to perform global-to-local coordinate conversion for hits and local-to-global conversion for output tracks
- Replaces simplified shift calculations in DQM with proper local coordinate transformations using rotation angles
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| RecoPPS/Local/plugins/CTPPSDiamondLocalTrackFitter.cc | Adds geometry-based coordinate transformations for hits and tracks, implementing bidirectional global/local conversions |
| DQM/CTPPS/plugins/CTPPSDiamondDQMSource.cc | Updates track position calculations to use proper local coordinates with rotation transformations instead of simple shifts |
This pull request introduces improvements to the handling of track coordinates in the
CTPPSDiamondDQMSourceandCTPPSDiamondLocalTrackFittermodules. The changes focus on incorporating rotation and translation transformations for better alignment with the detector geometry and adding support for global-to-local and local-to-global coordinate conversions.Enhancements in coordinate transformations:
DQM/CTPPS/plugins/CTPPSDiamondDQMSource.cc:diamShifts_withdiamTranslations_anddiamHalfWidths_for more accurate local coordinate calculations. Rotation angles are now applied usingdiamRotations_to adjust track positions. These changes impact the calculation ofstartBinfor both 220nr_hr and 220cyl tracks. [1] [2] [3] [4] [5]New support for global-to-local and local-to-global transformations:
RecoPPS/Local/plugins/CTPPSDiamondLocalTrackFitter.cc:edm::ESGetTokenfor accessingCTPPSGeometry, enabling geometry-based transformations.These changes improve the precision of track alignment and enhance compatibility with the detector geometry, which is critical for accurate data analysis.TODO