Skip to content

Fix notebooks for new RavenPy #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix notebooks for new RavenPy #524

wants to merge 4 commits into from

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Jul 24, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Updates the notebooks and re-runs all of them to esnure they are working with latest libraries
  • Adds a few missing testing data files to the pooch registry

Does this PR introduce a breaking change?

Yes. Testing data was added to the registry.txt so a new version of RavenPy is needed on PAVICS.

Other information:

We don't currently run the notebooks here in CI, as a few of them take far too long to compute. Perhaps we need to add a build for this regardless.

Changes here required for: Ouranosinc/PAVICS-e2e-workflow-tests#150

@Zeitsperre Zeitsperre requested review from huard and tlvu July 24, 2025 17:06
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coveralls
Copy link

coveralls commented Jul 24, 2025

Coverage Status

coverage: 80.752%. remained the same
when pulling 4af00fc on fix-notebooks
into b4c77c2 on master.

@Zeitsperre Zeitsperre self-assigned this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants