Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce Filter through json config working only for Field not for event https://github.com/COVESA/vsomeip/issues/704 #705

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Vignesh-Murugappan
Copy link

Debounce Filter through json config working only for Field not for event BUG #704

@Vignesh-Murugappan
Copy link
Author

Hi @GenivivSOMEIPmaintainer - Do you have any plan to take this to master?
Could you please review.

@vmurugap
Copy link

vmurugap commented Sep 5, 2024

@GenivivSOMEIPmaintainer : Could you please review and consider this for master branch if applicable

@duartenfonseca
Copy link
Collaborator

@Vignesh-Murugappan can you fix the conflicts? thanks, we will look into this PR

@Vignesh-Murugappan
Copy link
Author

@duartenfonseca Conflicts have been resolved!

@zhaoxin39913
Copy link

Hi @Vignesh-Murugappan, thanks for getting it fixed. Can we have it available in 3.5.2 or next release ?

@Vignesh-Murugappan
Copy link
Author

Vignesh-Murugappan commented Oct 25, 2024

@zhaoxin39913 Yeah sure, please take it for 3.5.2

Thanks!

@Vignesh-Murugappan
Copy link
Author

@zhaoxin39913 @duartenfonseca Is it possible to take this change for 3.5.3 or next release?

@Vignesh-Murugappan
Copy link
Author

@zhaoxin39913 @duartenfonseca is it possible to take this PR in next release?

@duartenfonseca
Copy link
Collaborator

@Vignesh-Murugappan isn't this network test https://github.com/COVESA/vsomeip/tree/master/test/network_tests/debounce_filter_tests a case of filtering an event?
can you demonstrate from that test what you would like to be able to do with the debounce filter?

@zhaoxin39913
Copy link

Hi @duartenfonseca

can we have this patch in next offical release (eg. 3.5.4) ?

@duartenfonseca
Copy link
Collaborator

Hi @duartenfonseca

can we have this patch in next offical release (eg. 3.5.4) ?

@zhaoxin39913 I was not able to reproduce the issue this fixes, can you help on this?

@duartenfonseca
Copy link
Collaborator

duartenfonseca commented Dec 31, 2024

@Vignesh-Murugappan / @zhaoxin39913
I was able to understand now the issue, if the vsomeip::event_type_e is ET_FIELD this functionality works, but when you change the type to ET_EVENT, it supposedly is not working.
The problem however is that in the network test that i mentioned previously (https://github.com/COVESA/vsomeip/tree/master/test/network_tests/debounce_filter_tests), if you change the mentions of ET_FIELD the test still filters correctly.
Can you try this approach on your side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants