Skip to content

Conversation

@scymtym
Copy link
Contributor

@scymtym scymtym commented Nov 25, 2024

Controls whether PointInTimeCriterion.process_data should forward fill temporal intervals.

Controls whether PointInTimeCriterion.process_data should forward fill
temporal intervals.

fixes #236
@scymtym scymtym requested a review from glichtner November 25, 2024 10:43
@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.57%. Comparing base (b3cdb36) to head (b0440f0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
execution_engine/omop/criterion/point_in_time.py 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   87.61%   87.57%   -0.05%     
==========================================
  Files          92       92              
  Lines        5852     5865      +13     
==========================================
+ Hits         5127     5136       +9     
- Misses        725      729       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

scymtym added a commit to DigiPOD/ee-addons that referenced this pull request Nov 25, 2024
The intervention criteria can change over time, including due to the
invertion being discontinued after some point in time. In such cases,
forward filling would hide the stop of the intervention.

Depends on CODEX-CELIDA/execution-engine#237.
@glichtner glichtner merged commit e89fcb3 into main Nov 25, 2024
1 of 3 checks passed
@glichtner glichtner deleted the forward-filling branch November 25, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants