Skip to content

Conversation

@zachcran
Copy link
Contributor

@zachcran zachcran commented Oct 27, 2025

Is this pull request associated with an issue(s)?
None.

Description
CMake versions that we test do not include CMake 4.x, so both the latest stable and release candidate versions of CMake are added for unit tests. The integration tests already test the latest release candidate, but don't use the most up to date syntax from lukka/get-cmake. The integration tests and unit tests should now test all of the same CMake versions.

This PR also simplifies the unit testing CI by using the lukka/get-cmake action instead of manually installing CMake.

TODOs

  • Ensure this actually runs on a GitHub runner.

@zachcran zachcran requested a review from ryanmrichard October 27, 2025 16:31
@zachcran zachcran self-assigned this Oct 27, 2025
@zachcran
Copy link
Contributor Author

@ryanmrichard r2g

@zachcran zachcran enabled auto-merge October 27, 2025 17:55
@zachcran
Copy link
Contributor Author

@ryanmrichard This is now succeeding with the changes from #170, so it should be good to go.

Copy link
Collaborator

@ryanmrichard ryanmrichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachcran zachcran merged commit e3506e0 into master Oct 27, 2025
10 checks passed
@zachcran zachcran deleted the update_ci_for_cmake_4 branch October 27, 2025 18:46
@github-actions
Copy link

🚀 [bumpr] Bumped!
New version:v1.1.10
Changes:v1.1.9...v1.1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants