generalize git dependencies #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmrichard
approved these changes
Jan 16, 2025
Collaborator
|
The integration tests are failing because they won't run from a fork. I'm going to suggest we merge this even with the failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No
Description
Non-GitHub repositories (e.g. GitLab) are all treated as
RemoteURLDependencys, which means they don't have aVERSIONparameter. Given that the current implementation ofRemoteURLDependencyactually usesGIT_REPOSITORY(as opposed toURL) when passing along toFetchContent, it is more accurate to call itGitDependency. This PR changes the name accordingly and moves theVERSIONparameter fromGitHubDependencyto the renamed class.