Skip to content

Sistrip calib tree devel2018 backplane #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robervalwalsh wants to merge 4 commits into
base: sitripCalibTreeDevel2018
Choose a base branch
from
Open

Sistrip calib tree devel2018 backplane #14

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f7aa4f
additional variables for backplane corrections studies
robervalwalsh Sep 28, 2020
4bfd9c1
fix reading the lorentz angles from the database
robervalwalsh Sep 28, 2020
b8eb4f2
new option for cosmicTriggers
robervalwalsh Sep 28, 2020
8344fde
Revert "fix reading the lorentz angles from the database"
robervalwalsh Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions CalibTracker/SiStripCommon/plugins/ShallowGainCalibration.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ ShallowGainCalibration::ShallowGainCalibration(const edm::ParameterSet& iConfig)
produces <std::vector<double> > ( Prefix + "gainused" + Suffix );
produces <std::vector<double> > ( Prefix + "gainusedTick" + Suffix );
produces <std::vector<float> > ( Prefix + "variance" + Suffix );
// for backplane corrections
produces <std::vector<float> > ( Prefix + "localx" + Suffix );
produces <std::vector<float> > ( Prefix + "rhlocalx" + Suffix );
produces <std::vector<float> > ( Prefix + "rhlocalxerr" + Suffix );
}

void ShallowGainCalibration::
Expand All @@ -55,6 +59,10 @@ produce(edm::Event& iEvent, const edm::EventSetup& iSetup) {
auto gainused = std::make_unique<std::vector<double>> ();
auto gainusedTick = std::make_unique<std::vector<double>> ();
auto variance = std::make_unique<std::vector<float>> ();
// for backplane corrections
auto localx = std::make_unique<std::vector<float>> ();
auto rhlocalx = std::make_unique<std::vector<float>> ();
auto rhlocalxerr = std::make_unique<std::vector<float>> ();

edm::ESHandle<TrackerGeometry> theTrackerGeometry; iSetup.get<TrackerDigiGeometryRecord>().get( theTrackerGeometry );
m_tracker=&(* theTrackerGeometry );
Expand All @@ -76,6 +84,8 @@ produce(edm::Event& iEvent, const edm::EventSetup& iSetup) {
const SiStripRecHit2D* sistripsimplehit = dynamic_cast<const SiStripRecHit2D*>(hit);
const SiStripMatchedRecHit2D* sistripmatchedhit = dynamic_cast<const SiStripMatchedRecHit2D*>(hit);
const SiPixelRecHit* sipixelhit = dynamic_cast<const SiPixelRecHit*>(hit);
// for the backplane corrections
const StripGeomDetUnit* theStripDet = dynamic_cast<const StripGeomDetUnit*>( theTrackerGeometry->idToDet( hit->geographicalId() ) );

const SiPixelCluster* PixelCluster = nullptr;
const SiStripCluster* StripCluster = nullptr;
Expand Down Expand Up @@ -114,6 +124,9 @@ produce(edm::Event& iEvent, const edm::EventSetup& iSetup) {
int FirstStrip = 0;
int NStrips = 0;
float Variance = -1;
float locx = -10;
float rhlocx = -10;
float rhlocxerr = -10;

if(StripCluster){
const auto & Ampls = StripCluster->amplitudes();
Expand Down Expand Up @@ -156,6 +169,10 @@ produce(edm::Event& iEvent, const edm::EventSetup& iSetup) {
const SiStripClusterInfo info(*StripCluster, iSetup, DetId);
Variance = info.variance();

locx = (theStripDet->toLocal(trajState.globalPosition())).x();
rhlocx = hit->localPosition().x();
rhlocxerr = sqrt(hit->localPositionError().xx());

}else if(PixelCluster){
const auto& Ampls = PixelCluster->pixelADC();
int FirstRow = PixelCluster->minPixelRow();
Expand Down Expand Up @@ -192,6 +209,11 @@ produce(edm::Event& iEvent, const edm::EventSetup& iSetup) {
gainused ->push_back( PrevGain );
gainusedTick ->push_back( PrevGainTick );
variance ->push_back( Variance );
// for the backplane corrections
localx->push_back(locx);
rhlocalx->push_back(rhlocx);
rhlocalxerr->push_back(rhlocxerr);

}
}
}
Expand All @@ -215,6 +237,11 @@ produce(edm::Event& iEvent, const edm::EventSetup& iSetup) {
iEvent.put(std::move(gainused), Prefix + "gainused" + Suffix );
iEvent.put(std::move(gainusedTick), Prefix + "gainusedTick" + Suffix );
iEvent.put(std::move(variance), Prefix + "variance" + Suffix );
// for the backplane corrections
iEvent.put(std::move(localx), Prefix + "localx" + Suffix );
iEvent.put(std::move(rhlocalx), Prefix + "rhlocalx" + Suffix );
iEvent.put(std::move(rhlocalxerr), Prefix + "rhlocalxerr" + Suffix );

}

/*
Expand Down
7 changes: 7 additions & 0 deletions CalibTracker/SiStripCommon/test/MakeCalibrationTrees/produceCalibrationTree_template_cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@
VarParsing.VarParsing.varType.int,
"run number to process (\"-1\" for all)")

options.register('cosmicTriggers','',
VarParsing.VarParsing.multiplicity.list,
VarParsing.VarParsing.varType.string,
'cosmic triggers')



Expand Down Expand Up @@ -154,6 +158,9 @@
)
)

if len(options.cosmicTriggers)>0:
print("cosmicTriggers : ", options.cosmicTriggers)
process.IsolatedMuonFilter.triggerConditions = cms.vstring(options.cosmicTriggers)


process.TkCalPath_StdBunch = cms.Path(process.TkCalSeq_StdBunch *process.shallowEventRun*process.eventInfo)
Expand Down
2 changes: 1 addition & 1 deletion CalibTracker/SiStripLorentzAngle/plugins/LorentzAngleRunInfo.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ void LorentzAngleRunInfo::beginRun(const edm::Run & irun, const edm::EventSetup
run = irun.run();
edm::ESHandle<TrackerGeometry> theTrackerGeometry; iSetup.get<TrackerDigiGeometryRecord>().get( theTrackerGeometry );
edm::ESHandle<MagneticField> magfield; iSetup.get<IdealMagneticFieldRecord>().get(magfield);
edm::ESHandle<SiStripLorentzAngle> SiStripLorentzAngle; iSetup.get<SiStripLorentzAngleDepRcd>().get(SiStripLorentzAngle);
edm::ESHandle<SiStripLorentzAngle> SiStripLorentzAngle; iSetup.get<SiStripLorentzAngleRcd>().get("deconvolution",SiStripLorentzAngle);
Copy link

@mmusich mmusich Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robervalwalsh Not sure why we need to hard-code "deco" here. Isn't it OK to consume the dependent record and let it deal with the latency switches?

Copy link
Author

@robervalwalsh robervalwalsh Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mmusich, I thought so, but the numbers coming out were different.

Copy link
Author

@robervalwalsh robervalwalsh Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, the values from the dependent record were also different from the ones in the payload inspector.

Copy link

@mmusich mmusich Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so, but the numbers coming out were different.

Because you were using some runs in peak?

Copy link

@mmusich mmusich Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, the values from the dependent record were also different from the ones in the payload inspector.

what run number did you check?

Copy link
Author

@robervalwalsh robervalwalsh Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure I was using a run in deco. I have to go through my notes to find it. May take a while


auto dets = theTrackerGeometry -> detsTIB();
dets.insert(dets.end(),(theTrackerGeometry -> detsTOB()).begin(),(theTrackerGeometry -> detsTOB()).end());
Expand Down