Merged
Conversation
Documentation:
- Rewrite CLAUDE.md with complete project structure and patterns
- Update GettingStarted.md with clearer instructions
- Update DevelopmentGuide.md with coding standards
- Rewrite Object docs (Electron, Muon, Jet, MET) with enum classes,
AnalyzerCore methods, and Run2/Run3 differences
Code changes:
- Update JES global tags to V3 for 2022/2022EE eras
- Remove jsonpog-integration submodule (corrections now in data/)
- Remove jsonpog update check from setup.sh
- Rename doThis.sh to scripts/convertEffRootFilesToJson.sh
- Clean up .gitignore
Contributor
|
good |
Collaborator
Author
|
@Chihwan-An reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsonpog-integrationas submodule and hardcoded in the main repository. Related setups are modified.GettingStarted.md, tried to follow the flow of first user's perspective (comment from Joon-Bin). Updated object documentation to follow current DataFormat modules.