GetJESSF, SystematicHelper, etc..#50
Merged
choij1589 merged 57 commits intoCMSSNU:mainfrom Jul 31, 2025
Merged
Conversation
Collaborator
|
Hi @yjk519 , micromamba works okay within singularity environment. DiLepton.cc missing systHelper update, but I will update it in the next PR. |
kyj519
added a commit
that referenced
this pull request
Aug 1, 2025
Following PR from #50 - JES tag updates + etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore
data/Run3_v12_Run2_v9.There have been many changes under this path, but since this version is being deprecated, you can safely ignore it.
Drop
SKFlat.pyentirely from the codebase.Many systematics are now decorrelated by era.
Added a
decorrelated_by_erafeature inSystematicHelper.cc—you must now supply aDataErain the constructor to use this.Constructor signature changed in
MyCorrection.cc.The b-tagging ROOT file selection can now vary per baseline selection; default initialization remains unchanged for backward compatibility.
Updated
template/run.sh&setup.shfor micromamba paths.They now handle cases where micromamba isn’t installed under
/opt. Please review to ensure alternative install locations work correctly.Modify setup script’s
SKNANO_HOME.It’s currently fixed to a custom directory—confirm if this was intentional or should be parameterized.
Added
phiparameter toGetJESSF.Jet-φ–dependent corrections were introduced in the 2023 BPix era, so we now pass
phiintoGetJESSF.