-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IWYU pragmas #1008
Add IWYU pragmas #1008
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 17 17
Lines 4546 4557 +11
Branches 0 971 +971
==========================================
+ Hits 4546 4557 +11 ☔ View full report in Codecov by Sentry. |
This looks OK to me. I am going to give @henryiii a few days to comment, then will merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very familiar with IWYU pragmas, but seems fine.
Oh, it is valid though to include individual headers (it's in the readme). It sounds like this will just point users to always including the conglomerate header? Shouldn't these (Config and formatter) have |
I looked through the Readme and didn't find any references to individually including headers except for the utilities (which I promptly forgot to correctly handle in my changes). Is it ok to include the "regular" headers (e.g. |
Added include-what-you-use pragmas to:
This should fix #816