Skip to content

Update tutorials: Tropical cyclone and engine impact data - #1111

Merged
spjuhel merged 5 commits into
developfrom
feature/trop_cyclone_tutorial
Dec 17, 2025
Merged

Update tutorials: Tropical cyclone and engine impact data#1111
spjuhel merged 5 commits into
developfrom
feature/trop_cyclone_tutorial

Conversation

@NicolasColombi

@NicolasColombi NicolasColombi commented Nov 19, 2025

Copy link
Copy Markdown
Collaborator

This PR is part of the ongoing effort to update all CLIMADA tutorials.

Changes proposed in this PR:

For the tropical cyclone tutorial:

  • Add section on track density and basin bounds
  • remove section on video (I took the liberty to do so as it is never used and I remember a conversation in which it seems that we wanted to systematically remove those sections from the tutorials, please tell me if this is not the case).
  • mild rephrasing.

For the engine impact data tutorial:

  • Use Log scale for x and y axis for better visualization instead of linear.

Both tutorials runs smoothly.

PR Author Checklist

PR Reviewer Checklist

@NicolasColombi NicolasColombi changed the title Feature/trop cyclone tutorial Update tutorial: Tropical cyclone and engine impact data Nov 19, 2025
@NicolasColombi NicolasColombi changed the title Update tutorial: Tropical cyclone and engine impact data Update tutorials: Tropical cyclone and engine impact data Nov 19, 2025
@NicolasColombi
NicolasColombi marked this pull request as ready for review November 19, 2025 15:26
@spjuhel

spjuhel commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator

I think the image of the plot with the log scale was not updated

Otherwise, good work, nice addition of the track density 👍
I also agree on removing the video part.

@NicolasColombi

Copy link
Copy Markdown
Collaborator Author

I think the image of the plot with the log scale was not updated

Otherwise, good work, nice addition of the track density 👍 I also agree on removing the video part.

Thanks Sam! for the log scale, I think I reverted the plot rendering to avoid committing these changes, but these lines should be uncommented plt.xscale("log") plt.yscale("log"). So I guess next time someone runs it it will appear. Does that makes sense ?

@spjuhel

spjuhel commented Nov 24, 2025

Copy link
Copy Markdown
Collaborator

Yes of course,
And it is good practice to remove the unnecessary changes in the jupyter notebooks from commits, but in this case we do want the new rendering in the tutorial to be shown (the tutorial displayed on the documentation website are not run again, they are a static version of their last commited state)

@NicolasColombi

Copy link
Copy Markdown
Collaborator Author

Yes of course, And it is good practice to remove the unnecessary changes in the jupyter notebooks from commits, but in this case we do want the new rendering in the tutorial to be shown (the tutorial displayed on the documentation website are not run again, they are a static version of their last commited state)

Agree, I just made a commit to show that. Let's wait for the test to run.
Other than that, ready to merge ?

@chahank chahank left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@spjuhel
spjuhel merged commit 4660c2a into develop Dec 17, 2025
12 of 16 checks passed
@emanuel-schmid
emanuel-schmid deleted the feature/trop_cyclone_tutorial branch February 25, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants