You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is part of the ongoing effort to update all CLIMADA tutorials.
Changes proposed in this PR:
For the tropical cyclone tutorial:
Add section on track density and basin bounds
remove section on video (I took the liberty to do so as it is never used and I remember a conversation in which it seems that we wanted to systematically remove those sections from the tutorials, please tell me if this is not the case).
mild rephrasing.
For the engine impact data tutorial:
Use Log scale for x and y axis for better visualization instead of linear.
NicolasColombi
changed the title
Feature/trop cyclone tutorial
Update tutorial: Tropical cyclone and engine impact data
Nov 19, 2025
NicolasColombi
changed the title
Update tutorial: Tropical cyclone and engine impact data
Update tutorials: Tropical cyclone and engine impact data
Nov 19, 2025
I think the image of the plot with the log scale was not updated
Otherwise, good work, nice addition of the track density 👍 I also agree on removing the video part.
Thanks Sam! for the log scale, I think I reverted the plot rendering to avoid committing these changes, but these lines should be uncommented plt.xscale("log") plt.yscale("log"). So I guess next time someone runs it it will appear. Does that makes sense ?
Yes of course,
And it is good practice to remove the unnecessary changes in the jupyter notebooks from commits, but in this case we do want the new rendering in the tutorial to be shown (the tutorial displayed on the documentation website are not run again, they are a static version of their last commited state)
Yes of course, And it is good practice to remove the unnecessary changes in the jupyter notebooks from commits, but in this case we do want the new rendering in the tutorial to be shown (the tutorial displayed on the documentation website are not run again, they are a static version of their last commited state)
Agree, I just made a commit to show that. Let's wait for the test to run.
Other than that, ready to merge ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the ongoing effort to update all CLIMADA tutorials.
Changes proposed in this PR:
For the tropical cyclone tutorial:
For the engine impact data tutorial:
Both tutorials runs smoothly.
PR Author Checklist
develop)PR Reviewer Checklist