-
Notifications
You must be signed in to change notification settings - Fork 161
pyproject definition #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyproject definition #1067
Changes from 5 commits
47bcfbb
e8ec43b
4ead073
cca65cf
52a9fde
be237a2
712d557
95b2e86
8fb3f8a
51f9147
23dc5e1
545211c
6fea680
a75e64a
798850b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,3 +1,106 @@ | ||||||
| [build-system] | ||||||
| requires = ["setuptools >= 64"] | ||||||
| requires = ["setuptools>=61", "setuptools_scm"] | ||||||
| build-backend = "setuptools.build_meta" | ||||||
|
|
||||||
| [project] | ||||||
| name = "climada" | ||||||
| version = "6.0.2-dev" | ||||||
| description = "CLIMADA in Python" | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| readme = "README.md" | ||||||
| requires-python = ">=3.10,<3.13" | ||||||
| license = { text = "GNU Lesser General Public License v3 (GPLv3)" } | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good catch! |
||||||
| authors = [ | ||||||
| { name = "ETH", email = "schmide@ethz.ch" } | ||||||
| ] | ||||||
| keywords = ["climate", "adaptation"] | ||||||
| classifiers = [ | ||||||
| "Development Status :: 4 - Beta", | ||||||
| "Programming Language :: Python :: 3", | ||||||
| "Topic :: Scientific/Engineering :: Atmospheric Science", | ||||||
| "Topic :: Scientific/Engineering :: GIS", | ||||||
| "Topic :: Scientific/Engineering :: Mathematics" | ||||||
| ] | ||||||
| dependencies = [ | ||||||
| "bayesian-optimization", | ||||||
| "bottleneck", | ||||||
| "cartopy", | ||||||
| "cfgrib", | ||||||
| "contextily", | ||||||
| "dask", | ||||||
| "deprecation", | ||||||
| "fiona", | ||||||
| "gdal", | ||||||
| "geopandas", | ||||||
| "h5py", | ||||||
| "haversine", | ||||||
| "matplotlib", | ||||||
| "netcdf4", | ||||||
| "numba", | ||||||
| "openpyxl", | ||||||
| "overpy", | ||||||
| "pandas", | ||||||
| "pathos", | ||||||
| "peewee", | ||||||
| "pillow", | ||||||
| "pint", | ||||||
| "pyarrow", | ||||||
| "pycountry", | ||||||
| "pyproj", | ||||||
| "rasterio", | ||||||
| "salib", | ||||||
| "scikit-learn", | ||||||
| "seaborn", | ||||||
| "sparse", | ||||||
| "statsmodels", | ||||||
| "tables", | ||||||
| "tabulate", | ||||||
| "tqdm", | ||||||
| "xarray", | ||||||
| "xlrd", | ||||||
| "xlsxwriter" | ||||||
| ] | ||||||
|
|
||||||
| [project.optional-dependencies] | ||||||
| doc = [ | ||||||
| "ipython", | ||||||
| "myst-nb", | ||||||
| "readthedocs-sphinx-ext>=2.2", | ||||||
| "sphinx", | ||||||
| "sphinx-book-theme", | ||||||
| "sphinx-markdown-tables", | ||||||
| "sphinx-design", | ||||||
| "sphinx-mdinclude" | ||||||
| ] | ||||||
| test = [ | ||||||
| "ipython", | ||||||
| "mccabe>=0.6", | ||||||
| "pylint>=3.0", | ||||||
| "pytest", | ||||||
| "pytest-cov", | ||||||
| "pytest-subtests" | ||||||
| ] | ||||||
| dev = [ | ||||||
| "ipython", | ||||||
| "myst-nb", | ||||||
| "readthedocs-sphinx-ext>=2.2", | ||||||
| "sphinx", | ||||||
| "sphinx-book-theme", | ||||||
| "sphinx-markdown-tables", | ||||||
| "sphinx-design", | ||||||
| "sphinx-mdinclude", | ||||||
| "mccabe>=0.6", | ||||||
| "pylint>=3.0", | ||||||
| "pytest", | ||||||
| "pytest-cov", | ||||||
| "pytest-subtests", | ||||||
| "pre-commit" | ||||||
| ] | ||||||
|
Comment on lines
+79
to
+82
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is very inconvenient. I think we should omit the "dev" shortcut then instead of duplicating the lists. |
||||||
|
|
||||||
| [project.urls] | ||||||
| Homepage = "https://github.com/CLIMADA-project/climada_python" | ||||||
|
|
||||||
| [tool.setuptools] | ||||||
| include-package-data = true | ||||||
|
|
||||||
| [tool.setuptools.packages.find] | ||||||
| include = ["climada*"] | ||||||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why reduce the version requirement for setuptools?
Why include
setuptools_scm? According to its docs:We hard-code the version in this file later on, so including this requirement serves no purpose (or does it? 🤷)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 changes reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turns out we actually need setuptools_scm for including package data