Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osdetection: add KDE Neon #1295

Closed
wants to merge 1 commit into from
Closed

osdetection: add KDE Neon #1295

wants to merge 1 commit into from

Conversation

luni3359
Copy link

Should close issue #1232, but I have a concern to point out:

VERSION_ID reports the version of the Ubuntu version that KDE Neon is based on, while VERSION shows the version of KDE Neon itself. From I read from the script, everyone always uses VERSION_ID for the OS_VERSION, so I didn't know which one to use here and went with the flow. I'm not sure which of the two versions matter the most.

Please let me know if this should be changed.

Contents of `/etc/os-release`
NAME="KDE neon"
VERSION="5.24"
ID=neon
ID_LIKE="ubuntu debian"
PRETTY_NAME="KDE neon User - 5.24"
VARIANT="User Edition"
VARIANT_ID=user
VERSION_ID="20.04"
HOME_URL="https://neon.kde.org/"
SUPPORT_URL="https://neon.kde.org/"
BUG_REPORT_URL="https://bugs.kde.org/"
LOGO=start-here-kde-neon
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

@mboelen
Copy link
Member

mboelen commented May 14, 2024

This had an unlucky merge conflict and the web editor won't let me fix it. So made a change manually: ba4cd63

Thanks for your contribution @luni3359

@mboelen mboelen closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants